smartdevicelink/sdl_javascript_suite

_preloadCellArtworks method's last line returns the opposite boolean of what it should

Closed this issue · 1 comments

Bug Report

In the choice set logic, the _preloadCellArtworks method has an error case checking for uploadResults.includes(false), but then returns that same value to determine the success of the method, when it should return the opposite value.

While this bug doesn't show itself in the most recent release of the library, with the upcoming release's refactoring of the ChoiceSetManager the library interprets the output of that method now and this is what causes the issue.

Expected Behavior

Try to upload valid choice sets. They get displayed on the head unit.

Observed Behavior

Choice sets fail if they have artworks attached

Browser & Version Information

JS Suite 1.5 on all environments. The bug itself is in 1.4 but only becomes an issue in 1.5

Closed via #496