smartive/zitadel-rust

Credentials and Reqwest SSL Implementation(s)

alienscience opened this issue · 1 comments

alienscience commented

TLDR

This crate uses both rustls and openssl. Because openssl can be difficult sometimes, it might be better to standardize on rustls.

Description

When using the credentials feature the following 2 dependencies are activated:

  1. openidconnect
  2. reqwest

openidconnect

The openidconnect dependency is pulled in with its default features:

  • oauth2
  • rustls-tls

These default features pull in the oauth2 dependency which then pulls in reqwest with rusttls-tls enabled.

reqwest

The reqwest dependency is included with its default features. This pulls in openssl when running on Linux/Docker. The final result of this is that the Zitadel crate includes a reqwest dependency that uses both rustls and openssl.

Suggested Solution

Normally, including extra unneeded dependencies is not a big problem, but openssl can be painful when building some docker images which do not include openssl in the base image (e.g Alpine Linux).

There is a simple one line change for this behaviour to standardize on rusttls and I can make a PR for this.

github-actions commented

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀