smartystreets/smartystreets-dotnet-sdk

Send Requests async

GrzesiekP opened this issue · 7 comments

GrzesiekP commented

Have you been thinking about adding SendAsync method ti IClient?
I've made a quick research and the biggest this is, that it would require cutting off .NET 3.5 as it does not support Task.

mdwhatcott commented

See previous discussion: #1 (comment)

  • 😕1
ryanjerskine commented

Any chance this could be revisited? I have a PR ready to go adding Async and dropping 3.5 and 4.0 since they aren't supported anymore.

joliver commented

Typically what we have seen is for those that need direct async support, they simply wrap the synchronous call in a Task and then use the async capabilities of the Task Parallel Library.

  • 😄1
  • 😕2
ryanjerskine commented

Typically what we have seen is for those that need direct async support, they simply wrap the synchronous call in a Task and then use the async capabilities of the Task Parallel Library.

That doesn't help me with anything. Using Task.Run will just pull another thread from the thread pool and block on that thread (slowing things down even more with the overhead of doing that). I'm wanting async for scalability, not to avoid blocking on a UI thread.

  • 👍5
jumpingjackson commented

Yeah i think its pretty silly there is no async api

  • 👍4
Fullmight commented

Like, "they simply wrap the synchronous call in a Task"? Git isuses are a weird place for a standup routine, and since we all know that doesn't work it has to be a joke right?

  • 😄1