smheidrich/py-json-stream-rs-tokenizer

Moving away from setup tools

kpcyrd opened this issue · 4 comments

kpcyrd commented

hello!

This project currently depends on setuptools-rust, from what I understand setuptools is deprecated and the project should instead use something like maturin to build a wheel. :)

Is there a way to build a wheel with the current tools? (I'm by far not an expert on this)

Thank you!

daggaz commented

@smheidrich is the expert here, but I think we're tied to setuptools-rust because maturin does support building optional extensions:
PyO3/maturin#1081

smheidrich commented

Exactly what @daggaz said. Maturin is a million times more convenient but without optional extension support we can't use it.

@kpcyrd I also haven't heard anything about setuptools or setuptools-rust getting deprecated, could you share a link if there were any announcements or plans of moving in that direction?

kpcyrd commented

It seems I've confused setuptools and setup.py: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

I also noticed python -m build works as expected and setup.py doesn't have to be used, so nothing to do here. 🙃

Thanks and sorry for bothering!

  • 👍1
smheidrich commented

I'll get rid of setup.py in favor of setup.cfg or pyproject.toml soon given that PyO3/setuptools-rust#208 has recently been implemented 👍