File common/crow_all.hpp doesn't conform to style requirements
Closed this issue · 8 comments
Things to fix:
- lines exceeding 80 chars
- indent size is 4 spaces, rather than 2
- missing license header
In fact, crow_all.hpp is not written by me, it's the library I use. The reason I included it because I made some minor changes to fit my need. I think I should remove it from our repo and regard it as a library requirement. In our later release, we should include a local copy of it. Phil, any suggestions?
If it has no copyright information associated with it at all, then we might not want to use it.
On May 13, 2015, at 10:21 AM, Wenzheng Li notifications@github.com wrote:
In fact, crow_all.hpp is not written by me, it's the library I use. The reason I included it because I made some minor changes to fit my need. I think I should remove it from our repo and regard it as a library requirement. In our later release, we should include a local copy of it. Phil, any suggestions?
—
Reply to this email directly or view it on GitHub.
Where did it come from and what did you change about it?
The change I made is minor, I just changed one function name IS_NUM to avoide the name conflict with the function in mysql++ library.
It does have a copyright notice, it's in that repository. If we use this, we have to include that.
Yeah, it does, it just didn't include the license in the header. I will remove the crow_all.hpp from our repository and refer users to the original repo.
I added crow as a submodule instead.