Rebase due to v5.18.1 incompatibility

Question

Rebase due to v5.18.1 incompatibility

Closed this issue 2 years ago · 16 comments

Hi,

Could you please update LRNG - with the release of kernel 5.18.1 (changes in drivers/char/random) LRNG stopped working. Thank you in advance!

@pfactum Could you please confirm?

Answer 1 · 2022-05-30T16:17:24.000Z

I can confirm that also, probably due the big changes in random.c.

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/drivers/char/random.c?id=v5.18.1&id2=v5.18

Answer 2 · 2022-05-30T16:52:39.000Z

Am Montag, 30. Mai 2022, 18:17:35 CEST schrieb ptr1337: Hi ptr1337,

I can confirm that also, probably due the big changes in random.c. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/driver s/char/random.c?id=v5.18.1&id2=v5.18

I wish you are kidding me - such massive changes in a stable kernel? Seriously? Anyways, I will have a look. Thanks for pointing me to this. Ciao Stephan

Answer 3 · 2022-05-30T17:50:44.000Z

@smuellerDD no kidding unfortunately :(, and thanks in advance for looking into this.

Answer 4 · 2022-05-30T20:00:06.000Z

Am Montag, 30. Mai 2022, 19:50:55 CEST schrieb Oleksandr Natalenko: Hi Oleksandr,

@smuellerDD no kidding unfortunately :(, and thanks in advance for looking into this.

Unbelievable such changes in an alleged stable kernel. Anyhow, please pull the updates. I only updated the C files for now and not the patches as I would like to wait for potential more changes over the next few "stable" releases. Can you please try the updates? Ciao Stephan

Answer 5 · 2022-05-30T20:14:51.000Z

I have prepared a patch that will allow you to make revisions:

https://github.com/sirlucjan/kernel-patches/blob/master/5.18/lrng-patches-v2-sep/0027-lrng-5.18-update-to-the-latest-git-HEAD.patch

However, I can let you know tomorrow at the earliest.

Answer 6 · 2022-05-30T20:23:41.000Z

Can you please try the updates?

Builds and boots fine for me, than you.

Answer 7 · 2022-05-30T20:28:43.000Z

@xanmod Alexandre, it looks like LRNG is working again.

Answer 8 · 2022-05-31T05:53:36.000Z

Am Montag, 30. Mai 2022, 22:15:01 CEST schrieb Piotr Górski: Hi Piotr,

I have prepared a patch that will allow you to make revisions: https://github.com/sirlucjan/kernel-patches/blob/master/5.18/lrng-patches-v2 -sep/0027-lrng-5.18-update-to-the-latest-git-HEAD.patch However, I can let you know tomorrow at the earliest.

Thanks for the hint that I could simply take 2 patches and form it into a "forward-patch". Thus I took the liberty to simply do a git format-patch and add the 2 patches into the repo as part of the "backport" patch directory. Thanks Ciao Stephan

Answer 9 · 2022-05-31T07:01:55.000Z

The problem seems to have been solved. Thanks a lot!

Answer 10 · 2022-05-31T08:05:06.000Z

@smuellerDD Update 5.15 patches too, please.

Answer 11 · 2022-05-31T11:47:35.000Z

Am Dienstag, 31. Mai 2022, 10:05:16 CEST schrieb Vladdrako: Hi Vladdrako,

@smuellerDD Update 5.15 patches too, please.

What issues do you see with 5.15? Ciao Stephan

Answer 12 · 2022-05-31T12:02:29.000Z

Probably exactly the same as in 5.18 - changes in drivers/char/random.c

Answer 13 · 2022-05-31T12:07:23.000Z

Am Dienstag, 31. Mai 2022, 14:02:39 CEST schrieb Piotr Górski: Hi Piotr,

Probably exactly the same as in 5.18 - changes in drivers/char/random.c

Can you point me to the 5.15 version you are seeing the issues with? Using 5.15.0 all was good. Ciao Stephan

Answer 14 · 2022-05-31T13:02:16.000Z

What issues do you see with 5.15?

5.15.44 provides massive rng refactoring. So, lrng didn't compile anymore. Also, patches from backports and kernel_patches folders are conflicted. Probably because in kernel_patches v43, in backports v45.

Answer 15 · 2022-05-31T13:12:28.000Z

Am Dienstag, 31. Mai 2022, 15:02:27 CEST schrieb Vladdrako: Hi Vladdrako,

> What issues do you see with 5.15? 5.15.44 provides massive rng refactoring. So, lrng didn't compile anymore. Also, patches from backports and kernel_patches folders are conflicted. Probably because in kernel_patches v43, in backports v45.

Oh my. Shaking my head. Thanks for the reference. I will take a look. Ciao Stephan

Answer 16 · 2022-10-11T07:57:55.000Z

Am Dienstag, 31. Mai 2022, 15:02:27 CEST schrieb Vladdrako: Hi Vladdrako,

> What issues do you see with 5.15? 5.15.44 provides massive rng refactoring. So, lrng didn't compile anymore. Also, patches from backports and kernel_patches folders are conflicted. Probably because in kernel_patches v43, in backports v45.

The culprit was the same changes applicable to 5.18.1 are now needed for 5.15.44. The provided updated patch should do it. Ciao Stephan