sid timeout for long-lasting instances

Question

sid timeout for long-lasting instances

cmsimike opened this issue 7 years ago · 8 comments

Hi,

I have come from the home-assistant community where we're having an issue around SIDs expiring and causing any instanced SurveillanceStation instances to become stale, requiring a full restart of the app.

What are your thoughts about your library silently re-establishing connections in cases like that? Meaning when you get an exception from Synology:
home-assistant/core#12037

Just recreate the API?

Answer 1 · 2018-02-28T21:10:10.000Z

Thanks for raising this, I'll have a look this weekend to see what should be done. Ideally this should be handled inside this lib

Answer 2 · 2018-02-28T21:20:33.000Z

@snjoetw Thank you for the response! I'll put my hass PR into a WIP state (I fix this manually in there) but if the connection can be re-established inside your lib, I think that would be the absolute best.

Answer 3 · 2018-03-04T06:14:22.000Z

@cmsimike what do you think of this PR? #4

Answer 4 · 2018-03-05T23:42:43.000Z

@snjoetw Thank you for your work on this, and apologies for the delay in getting back to you. I will test this out and let you know.

Answer 5 · 2018-03-06T00:29:10.000Z

Installed! Ill report back in a few days.

Answer 6 · 2018-03-06T07:02:02.000Z

Thanks! Hopefully this fixes your problem.

btw how do you reproduce it? Do you just leave it run for a few days and it’ll start erroring out?

It’s weird that I’ve never seen the error myself. I have a DS216+II with DSM 6.2

Answer 7 · 2018-03-06T07:12:15.000Z

Exactly that. I (unfortunately) never paid too much attention when it goes out but eventually after a few days the cameras won't load anymore and I am spammed in the log with exception.

Answer 8 · 2018-03-11T07:06:23.000Z

Closing this one and will integrate with next home assistant release