snowfire/Beautymail

remove empty colspan

avp90 opened this issue · 4 comments

avp90 commented

Can you remove the empty colspan (without side effects) in sunny\contentEnd.blade.php?

<tr>
	<td colspan="3" height="30"></td>
</tr>

To enable more flexible layouts like:

    @include ('beautymail::templates.sunny.heading' , [
                'heading' => $heading,
                'level' => 'h1',
            ])
    @include('beautymail::templates.sunny.contentStart')
    ... $intro
    @include('beautymail::templates.sunny.contentEnd')
    @isset($actionText)
        @include('beautymail::templates.sunny.button', [
                'title' => $actionText,
                'link' => $actionUrl
        ])
    @endisset
    @include('beautymail::templates.sunny.contentStart')
    ... $outro
    @include('beautymail::templates.sunny.contentEnd')

The best way to test this is to use https://litmus.com/ and send test emails before/after the change.

avp90 commented

It worked in my test cases. Can you remove it in your repo?

Great! Can you share your Litmus test link here?

avp90 commented

I don't test it with Litmus.