snudatalab/KegNet

Small error in the code (tensorly.decomposition.parital_tucker)

dohe0342 opened this issue · 1 comments

dohe0342 commented

Hello, first of all thanks for good research.

There is a small error in the code.

KegNet/src/kegnet/utils/tucker.py line 90-91:
image

Third argument of decomp.partial_tucker is rank, not ranks.
image

Thanks.

jaeminyoo commented

Thanks for the comment. The ranks option was in TensorLy 0.4.3 when we were writing the paper, but it seems the option is not available in the current version.