socketio/socket.io-adapter

rooms and sids are protected

ejose19 opened this issue · 1 comments

ejose19 commented

Refers to socketio/socket.io#3697

Is there any particular reason you made those protected? If it's to not allow modifications from the outside, shouldn't we provide getRooms and getSids to act as getters? I can work on a PR if this is the approved solution.

darrachequesne commented

Let's make them public then: 313c5a9

Included in socket.io-adapter@2.1.0 & socket.io@3.1.0.