Iframe fallback refers to old version of SockJS-Client
holloway opened this issue · 5 comments
I'm not sure if this is a bug or not, but on line 146 of sockjs.coffee there's a URL specified that's an old version of the SockJS-Client.
Should this be upgraded, or should users wanting a newer version just override the sockjs_url option?
fyi It's causing a bug in create-react-app.
We should probably update it to be the latest in 1.X https://cdn.jsdelivr.net/sockjs/1/sockjs.min.js
A new user of sock-js but why is the CDN URL included at all?
@raybooysen Please read the documentation before asking questions: https://github.com/sockjs/sockjs-node#server-class
Hi @brycekahle, I have read the documentation, but this is more a discussion about why it is included at all. The documentation says:
This iframe also does need to load SockJS javascript client library, and this option lets you specify its url (if you're unsure, point it to the latest minified SockJS client release, this is the default)
It would seem prudent to make it required instead of falling back to something that needs to make a call across the internet, and removes the class of bugs around out of date CDN URLs.
e6eeb42 updated the URL to be the latest 1.x release of sockjs-client. Closing this issue.