sofn-xyz/mailing

Feature request: password protected preview site

maxsalven opened this issue · 5 comments

maxsalven commented

I'd love to be able to password protect the entire preview site when I deploy it to production. I see that protections are available for the API routes but anyone who knows my Vercel URL can see all preview emails. I'd like to limit this to approved collaborators through a password.

alexfarrill commented

Hey there Max, this would be a welcome feature and we would be happy to review a PR. Thanks for making the issue!

  • 👍1
jpalumickas commented

Hey, also would be nice to disable previews with ENV variable (for example DISABLE_PREVIEWS=true) in production. Maybe this would be easer to implement?

alexfarrill commented

@jpalumickas Thanks for the idea! cc: @maxsalven

I've released a beta version 0.9.10-next.0 that implements this. If you set DISABLE_PREVIEWS to something truthy, previews will be disabled.

Would you try it out and let me know if this solves your problem?

Thanks

jpalumickas commented

@alexfarrill it's working! maybe DISABLE_PREVIEWS check should be added to pages/index.ts to not do redirection to previews?

alexfarrill commented

@jpalumickas @maxsalven This is released in 0.9.11. Thank you again for using Mailing!