Activate production build in dockerfile of dashboard

Question

Activate production build in dockerfile of dashboard

rmllr opened this issue 5 years ago · 3 comments

At the moment the development build is used for the docker image of the dashboard.

Compiled successfully!
You can now view @coreui/coreui-free-react-admin-template in the browser.
Local: http://localhost:3000/
On Your Network: http://XXX.XXX.XXX.XXX:3000/
Note that the development build is not optimized.
To create a production build, use npm run build.

Please change it to production build.

Answer 1 · 2019-04-19T20:12:18.000Z

@rmllr The production build should now be served when running the docker image. Please test and merge my fix to master if everything works fine. :)

Answer 2 · 2019-04-23T06:27:49.000Z

@tmewes Thanks for developing the enhancement. To my mind, it would be an additional improvement if you reference the existing environment variable named PORT in the dockerfile. Currently, it is a hard coded 3000.

What do you think?

Answer 3 · 2019-04-23T11:05:51.000Z

@rmllr Good idea. I have adapted the Dockerfile and the README accordingly. Please note that the call to 'docker run' has changed slightly so that Docker can successfully access the variables.