softwarerero/meteor-accounts-t9n

username and email placeholder does not translate on signUp atForm

spiotr12 opened this issue ยท 13 comments

As in title. It works on signIn but does not work on signUp. Or more precisely the placeholder. Password for instance works fine. See screens:
2017-01-05_00h57_04
2017-01-05_00h57_11
2017-01-05_00h57_32
2017-01-05_00h57_41

This is my code
const pwdField = AccountsTemplates.removeField('password'); AccountsTemplates.removeField('email'); AccountsTemplates.addFields([ { _id: "username", type: "text", required: true, displayName: "username", re: /^[a-zA-Z0-9_-]{5,}$/, minLength: 5, }, { _id: 'email', type: 'email', required: true, displayName: "email", re: /.+@(.+){2,}\.(.+){2,}/, errStr: 'Invalid email', }, pwdField ]);

I can't see how this code can produce the screens you show. There must be more code. Is AccountsTemplates your object or is it from a library?

It's from library

There is another missing translation "minimum required length" in help-block
sketch-1483575408206

I strongly believe that you have to look in that library why some strings are not translated. If you just find a translation missing for you language in t9n feel free to add it, pull requests are always welcome.

Okay ๐Ÿ‘

Hi. So I did as you suggested, I've added missing translations in polish ;) there are two commits for pull request [ main and my typo ](its is my very first one). I hope I've done it correctly.

Looks good to me, although I don't understand polish. Thanks.

Not a problem, I'm glad I could help ๐Ÿ‘

Last question: how do I update my project to have these changes included in app?

I just published a new release 1.3.7. If you are on a recent Meteor version you should be able to change that version in package.json and call meteor npm install.

Great, I've updated it to 1.3.7 ๐Ÿ‘

However It still does not change the error message.... (I've run meteor reset command as well - no luck)
2017-01-07_18h00_13

Any idea?
I think if I declare new keys then I could just override it - walk around
But as we've just added translations this should work right?

*I'm testing only that message right now

Thanks for your help

Without knowing the source code it is difficult to help.

Closing this as I have no idea how to help here.