Check use of parent methods by composite comps
dinkelbachjan opened this issue · 2 comments
A developer of a certain CompositePowerComp should implement custom behaviours for Initialize, ApplySystemMatrixStamp etc. by means of the mnaParent... methods and not by means of the mnaComp... methods of the composite component class. So I would propose to use here override final for all mnaComp... methods.
Marking as override final is not feasible yet, since several composite components (e.g. DP_Ph1_Transformer.h) do override mnaComp... methods. It needs to be double-checked whether this is really required in all cases, or whether instead mnaParent... can be used instead and the override final marking realized.
Probably override final limits flexibility to much. Nonetheless, double-check whether composite components could use mnaParent... instead of mnaComp...