soixantecircuits/idle-vue

Don't include idle-vue component in default build

Closed this issue · 7 comments

For most people this is just bloat, most people will not use this component so you're just adding kB to their JS asset size. Just include it in the package as an example or to be extended or whatever. Anyone who wants to use this component can include it themselves.

For most people it will not work properly since it tried to request a PNG icon at a path that almost nobody will use.

Totally agree. This will be removed in the next version. In the mean time if you fix this, we will be happy to merge.

@gabrielstuff Firstly, nice package!

This issue is a nice addition. Do you intend to merge and publish?

Thanks.

Hello,
Yes testing tomorrow with fixing #20

When will this be merged?

I see this was merged in but a new release was not published to NPM.

#28

Will publish tonight.