pushing to PRs doesn't clear past approvals

[t-nelson]

not ideal. please enable Dismiss stale pull request approvals when new commits are pushed for all branch protection rules

[t-nelson]

cc/ @jacobcreech

[jacobcreech]

@t-nelson did you see stale approvals not get dismissed somewhere? I've seen the expected behavior during reviews thus far.

[t-nelson]

yeah here. #105 (review)

though i notice now that the checkmark/approval is white instead of green. maybe this is a github ux "improvement" 🤔

[jacobcreech]

@t-nelson I think it only dismisses those approvals with write access instead of triage. You only have triage at this time and it didn't remove your checkmark, while Richie's was removed with his write access.

[ripatel-fd]

I'm closing this as completed since the suggested action was taken. @t-nelson Please feel free to reopen if you think this needs further work.