solarus-games/zsdx

Low hearts beeping sound in end screen

christopho opened this issue · 5 comments

If you have only a few hearts remaining when you beat the final boss, you will hear the beeping sound during the end screen, after the credits.

I can reproduce the bug sometimes but not always. I don't know how to reproduce it reliably yet.

i think i found why :

in map "the end", function on_started, you wrote
if destination == from_ending

isn't "from_ending" supposed to be a string instead of a variable ?

No, it is a variable. The destination parameter passed is not a string, it is an object of type entity.

May it depends on the status of the timer who refresh the health status ? Like if the timer here https://github.com/christopho/zsdx/blob/master/data/hud/hearts.lua#L112 is called when the map is changing to the end, the sound is repeated ?

Cannot reproduce anymore with Solarus 1.5.