'multer': middleware not shipped with dev-app standalone tar.gz

Question

'multer': middleware not shipped with dev-app standalone tar.gz

Closed this issue 8 years ago · 20 comments

@brunobottazzini
multer node module does not come together with soletta-dev-app_standalone_v1_beta10.tar.gz and cause dev-app-server not able to start.
User need to manually run npm to install it.
Can this be included in the package or recipe?

anselmolsm commented 8 years ago

PR #146

Answer 1 · 2016-10-10T12:32:32.000Z

Hi @brunobottazzini & @bdilly,

With the soletta-dev-app v1_beta10 package and meta-soletta v10, we are encountering that soletta-dev-app-server.service can not be loaded. Below showing the error message:

root@intel-corei7-64:~# /usr/bin/node /opt/soletta-dev-app/server/app.js
module.js:338
    throw err;
          ^
Error: Cannot find module 'multer'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at module.exports (/opt/soletta-dev-app/server/tools.js:20:18)
    at /opt/soletta-dev-app/server/routes.js:24:26
    at Object.<anonymous> (/opt/soletta-dev-app/server/routes.js:477:2)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)

Can the "multer" dependency issue being solved at meta-soletta soletta-dev-app_git.bb file?

Thanks & Regards,
Wilson

Answer 2 · 2016-10-13T12:21:01.000Z

@fulong82 FYI I uploaded a PR solettaproject/meta-soletta#113 for this issue

@ceolin @edersondisouza could you share more information about the file soletta-dev-app_standalone_v1_beta10.tar.gz? how to generate this .tar.gz file? I execute the "install.sh" script in soletta-dev-app, and found it is different than this .tar.gz file. A lot of node_modules/* files are missing in the .tar.gz file

Answer 3 · 2016-10-18T22:45:30.000Z

Please check my comment at solettaproject/meta-soletta#113 and https://github.com/solettaproject/soletta-dev-app/releases/tag/v1_beta11 as well.

Answer 4 · 2016-10-24T01:58:40.000Z

@anselmolsm @fulong82
Thanks for generating the package.
I have tested the package and I found there is a lib file that might cause issue.
selenium-webdriver/lib/firefox/i386/libnoblur.so
In my build it complains architecture mismatch since I am building for x64 system.

Answer 5 · 2016-10-24T03:21:55.000Z

I am wondering why original package does not suffer this platform dependent issue. Is current package creating method different from the original one?

Answer 6 · 2016-10-24T04:09:52.000Z

@peijiajames This particular node module is not in the previous release.
I am not sure how the package is generated but there is slightly different in the content of package.json
and everything else seems working well.

Answer 7 · 2016-10-24T13:56:29.000Z

Hey @peijiajames @chongyic . Yes, I saw bitbake complaints about this binary, I had to remove the 32-bit .so while generating for x86_64.
Notice modules listed in package.json bring their own dependencies as well, that's why the content of node_modules contains more things than listed in package.json.

Answer 8 · 2016-10-24T13:57:56.000Z

@peijiajames since there is no info regarding the package generation, we can assume it is different.

Answer 9 · 2016-10-24T22:56:38.000Z

v1_beta11-2 package: node_modules dir content reduced from 134 to 38 with npm prune --production. This also removed the selenium-webdriver binary mentioned above.

I'll submit a PR with a simple script to generate the release package, so we can work on it for other improvements.

Answer 10 · 2016-10-25T06:30:01.000Z

@anselmolsm thanks for the update. Yes, as the original process is not clear defined, it's better to clarify it now :)

@chongyic can you check if v1_beta11-2 package solve the problem your are facing?

Answer 11 · 2016-10-27T07:23:42.000Z

@chongyic @fulong82 did you have a chance to test v1_beta11-2 package for multer issue?

Answer 12 · 2016-10-27T07:25:36.000Z

Hi @peijiajames
@fulong82 and I already tested the package and it is working fine.
Thanks.

Answer 13 · 2016-10-27T07:32:41.000Z

@chongyic thanks. Then do you think we can close this task now?

BTW, I see @anselmolsm started the effort of dev-app package generation script, and I think it worth another task as it is general script improvement rather than multer module issue. @anselmolsm your idea?

Answer 14 · 2016-10-27T07:37:36.000Z

Hi @peijiajames,

The package is ok, but how about the soletta-dev-app_git.bb fix for using the working tarball?
solettaproject/meta-soletta#113

Answer 15 · 2016-10-27T07:44:42.000Z

@fulong82 I think #113 should be abandoned. the .bb file should use the downloaded beta11-2 .tar.gz file

Answer 16 · 2016-10-27T07:50:29.000Z

Agree. I think #113 is the hacker way for adding multer dependency in BB file manually. It is not needed as we already have the official package generation script solution from @anselmolsm :)

Answer 17 · 2016-10-27T07:53:59.000Z

@yongli3 So do you mean you will abandon the implementation in PR#113 and re-submit the changes below for PR#113 or create new PR?

Answer 18 · 2016-10-27T08:17:20.000Z

YES @fulong82 please check on solettaproject/meta-soletta#115

Answer 19 · 2016-10-27T11:19:35.000Z

BTW, I see @anselmolsm started the effort of dev-app package generation script

Yes, please see PR #146.

When that PR gets merged, we can close this issue.