soliantconsulting/tagmanager

Usage of "delete" and "import" function names in JS

Closed this issue · 1 comments

splattne commented

The TagManager object has two functions (prototype) which are reserved keywords in JavaScript: delete and import.

It's not a bug per se, but some JS minifiers aren't able to handle this.

I suggest renaming the functions to

  • deleteTag
  • importTags (which unfortunately is a breaking change)
TomHAnderson commented

These have been changed to remove and populate.