Add operator argument to `ERC20` `_beforeTokenTransfer` hook

Question

Add operator argument to `ERC20` `_beforeTokenTransfer` hook

ItsNickBarry opened this issue 4 years ago · 3 comments

Investigate whether this is useful.

Answer 1 · 2021-07-25T02:55:59.000Z

The ERC1155 usage of operator in its hook of the same name does not appear to be useful because it is always set to msg.sender. Should operator be set to address(this) for the mint and burn functions?

Answer 2 · 2021-07-25T03:10:29.000Z

Other option is to remove operator entirely, simplifying the internal API.

Answer 3 · 2021-07-25T04:51:52.000Z

Apparently operator is an integral part of the ERC1155 standard, so it doesn't make sense to change its meaning even in the context of _beforeTokenTransfer.