Remove overload-based nesting from test suites
ItsNickBarry opened this issue · 0 comments
ItsNickBarry commented
Overloaded functions should be treated as separate for the purposes of testing. Non-overloaded functions should also include the full function signature in the test suite description. The following is an example of the requested change from MinimalProxyFactory.ts
.
Before:
describe('#_deployMinimalProxy', function () {
describe('(address)', function () {
// ...
});
describe('(address,bytes32)', function () {
// ...
});
});
describe('#_calculateMinimalProxyDeploymentAddress', function () {
// ...
});
After:
describe('#_deployMinimalProxy(address)', function () {
// ...
});
describe('#_deployMinimalProxy(address,bytes32)', function () {
// ...
});
describe('#_calculateMinimalProxyDeploymentAddress(address,bytes32)', function () {
// ...
});