solvebio/solvebio-python

[Vaults] create_folder ignores path kwarg

Closed this issue · 3 comments

The path kwarg is ingored in create_folder and the folder is just created at the root.

# this just creates my_new_folder in vault root
vault.create_folder('my_new_folder', path='/some/path')

workaround is to get the ID of the parent and pass that through

parent_folder = Object.get_by_full_path(vault.full_path + ":/some/path")
vault.create_folder('my_new_folder', parent_object_id=parent_folder.id)

can be fixed by copying the logic in vault.create_dataset() shortcut

the issue us that path is a read only parameter in the Object serializer