somish/NexusMutual

Changes delegateCallBack

Closed this issue · 4 comments

nitika-goel commented
  • Call pd.updateDateUpdOfAPI(myid); once, instead of each if statement
  • Use checkPause instead of if (ms.isPause() == false)
  • Fetch pd.getApiIdTypeOf(myid) once instead of calling it repeatedly in each if condition
nervehammer commented

@nitika-goel the second point cannot be done if we use a checkPause modifier as if the system is in the Emergency Pause state, the oraclize call for removing emergency pause will simply throw

nitika-goel commented

Ah ok! Makes sense! Let's skip the 2nd one.

nervehammer commented

done, please refer 41196fc

nitika-goel commented

Further changes in f6109b7
Closing issue