[RFC] `global_ignore_columns` param should be renamed to `global_ignore_fields`
phansys opened this issue · 8 comments
| Q | A |
|---|---|
| Bug report? | yes |
| Feature request? | no |
| BC Break report? | no |
| Used Version | 1.0.9 |
global_ignore_columns param must be renamed to global_ignore_fields, since its values are checked against field names instead column names.
I think we could deprecate it, explaining the new one must be used.
IIRC both configuration names are working currently, leaving the old (columns) only for compat reasons, but I might be confusing this with another ignore-config variable.
In latest 1.x tag (currently v1.0.9), there is just global_ignore_columns config option: https://github.com/simplethings/EntityAuditBundle/blob/5725ecab2d132288842d9a075d1a8662520829c5/src/SimpleThings/EntityAudit/DependencyInjection/Configuration.php#L18-L20
#213 was made against master, even, that option is currently not part of that branch (2df48c3#diff-7005d8857f97a86a6140690466b7723f).
Hmm, I could have sworn, that PR was older than the 1.x-branch, sorry about the confusion. I guess it's time to decide about master branch being reverted to/merged with 1.x to avoid a complete halt in development.
Last I heard from @DavidBadura it sounded, like he wouldn't finish the master refactoring if at all - any changes there @DavidBadura? Is the lib + bundle split still happening or should we abandon that?
#213 was part of 1.x branch (1d06f6f). It is present at v1.0.1, but it was completelly removed at v1.0.3: (v1.0.1...v1.0.3).
weird, probably by mistake
Can I help? Please, don't hesitate to share your concerns.
Thank you in advance!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.