sonata-project/SonataDoctrinePhpcrAdminBundle

Use PropertyAccess instead of reflection

Closed this issue · 2 comments

dbu commented

ModelManager::modelReverseTransform is using reflection instead of PropertyAccess

wouterj commented

Is this really wanted? I was about to fix this PR, but I think it does some things differently:

  • SonataDoctrineOrmBundle is using reflection as well, it would be nice to have this all consistent (behaviour expectations)
  • Currently, the value is always set (one way of another). If it's not via setters, public properties or the like, it's using ReflectionProperty from Doctrine's metadata. With the PropertyAccessor, there has to be a public property or setter in other to use it.
dbu commented

ok, lets opt for consistency then