sonata-project/SonataPageBundle

Switch cocur/slugify to symfony/string

eerison opened this issue · 6 comments

Switch cocur/slugify to symfony/string

in order to use more symfony packages and keep this repo using the same dependencies as admin bundle

I suggest we change slugify to symfony/string!

in case it makes sense, then I will try to do it :D

in case it makes sense, then I will try to do it :D

Sure it make sense ; but I dunno if we'll be able to drop the dependency in a BC way.

Pr is opened.

Yeah, we need to keep the dependency in 4.x and remove in 5.x only.

We need the both dependencies to keep BC compatibility

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@eerison Any chance you could finish this?

Hello @haivala

unfortunately I am without free time :/