sonata-project/sandbox

How to make tests green - TODO list

Closed this issue · 3 comments

wbloszyk commented

From some time I working on prepare stable 3.0. The first step was remove dependencies which block me to use the latest sonata bundles. - #986.

Here is list what to must be done to make tests green:

  • sonata-project/ecommerce#773
  • release ecommerce with 773
  • make this services public (BlockBundle v3)
    • sonata.block.context_manager,
    • sonata.block.renderer
    • sonata.block.cache.handle
  • fix Sonata\PageBundle\Command\RenderBlockCommand
  • fix cache commands or disable i until support symfony/cache
  • fix failures from sonata-project/notification-bundle
wbloszyk commented

We can avoid making block services public by present BC-break in PageBundle. Then services will be injected instead taking from container. We present BC-break like this in other bundles, which will also remove deprecation from ContainerAwareCommand.

VincentLanglet commented

We can avoid making block services public by present BC-break in PageBundle. Then services will be injected instead taking from container. We present BC-break like this in other bundles, which will also remove deprecation from ContainerAwareCommand.

I'm fine with this. Do you have time to do the PR ?

github-actions commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.