sonic-net/sonic-sairedis

[LAG] received extra error log "unable to get RID for VID" even when code flow handle this exception successfully

ayurkiv-nvda opened this issue · 4 comments

Description

Sometimes, when port/LAG becomes removed, "Flex counter" logic do checking in that moment and find out that there is no RID for VID.
We are trying to translate VID to RID and if it fails we throw WARNING message.
This message does not have any functional impact, it just notifies the user that SONiC tried to poll counters for the port-channel which was removed

if (!m_translator->tryTranslateVidToRid(vid, rid))
 {
     SWSS_LOG_WARN("port VID %s, was not found (probably port was removed/splitted) and will remove from counters now",
             sai_serialize_object_id(vid).c_str());

     op = DEL_COMMAND;
 } 

The flow is valid, exception is handled successfully, but we also receive extra ERR message from tryTranslateVidToRid function that confuse user:

Dec 16 12:48:58.543198 r-panther-13 ERR syncd#SDK: :- translateVidToRid: unable to get RID for VID oid:0x60000000007c2
Dec 16 12:48:58.543198 r-panther-13 WARNING syncd#SDK: :- processFlexCounterEvent: port VID oid:0x60000000007c2, was not found (probably port was removed/splitted) and will remove from counters now

I expect that ERROR message we should receive only if problem was not handled.

Steps to reproduce the issue:

  1. remove LAG just before "flex counter" logic will do check for RID

Describe the results you received:

Dec 16 12:48:58.543198 r-panther-13 ERR syncd#SDK: :- translateVidToRid: unable to get RID for VID oid:0x60000000007c2
Dec 16 12:48:58.543198 r-panther-13 WARNING syncd#SDK: :- processFlexCounterEvent: port VID oid:0x60000000007c2, was not found (probably port was removed/splitted) and will remove from counters now

Describe the results you expected:

only

Dec 16 12:48:58.543198 r-panther-13 WARNING syncd#SDK: :- processFlexCounterEvent: port VID oid:0x60000000007c2, was not found (probably port was removed/splitted) and will remove from counters now

Output of show version:

SONiC-OS-202106_rc1_build_fix.1-8bde5b4ff_Internal

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

Is this still there?

Is this still there?

@zhangyanzhao

Reproduced on 202106.84-212cdfbe8_Internal

May 19 15:31:09.664353 r-spider-05 ERR syncd#SDK: :- translateVidToRid: unable to get RID for VID oid:0x6000000000be2

@kcudnik , can you take a look at this first?

Fix here: #1048