NoMethodError undefined method `find'

Question

NoMethodError undefined method `find'

ysgard opened this issue 7 years ago · 13 comments

Getting this after a recent upgrade to fluentd:

2017-06-27 17:54:46 +0000 [warn]: #0 reemit: NoMethodError undefined method `find' for nil:NilClass /opt/td-agent/embedded/lib/ruby/gems/2.1.0/gems/fluent-plugin-reemit-0.2.1/lib/fluent/plugin/out_reemit.rb:133:in `match'

using fluent 0.14.18 and fluent-plugin-reemit 0.2.1

Answer 1 · 2017-06-27T19:42:37.000Z

I see that a fix was committed for this 8dbf1e5, but the gem in RubyGems doesn't have the fix.

Answer 2 · 2017-06-27T20:43:05.000Z

I downloaded and built the gem, using a local gem server. However although I'm seeing the new code now, it still bombs with the same error:

2017-06-27 20:29:48 +0000 [warn]: #0 reemit: NoMethodError undefined method `find' for nil:NilClass /opt/td-agent/embedded/lib/ruby/gems/2.1.0/gems/fluent-plugin-reemit-0.2.2/lib/fluent/plugin/out_reemit.rb:154:in `match'

Looking at the code, that corresponds to this:

 def match(tag)
        # We want to reemit messages to the next `<match>` below this `type reemit`
        # to avoid reemiting back to an above or current `<match>`
        found_reemit = false
        @matches.find do |m|      <---- @matches is nil
          if m.match(tag)
            if found_reemit && !@reemit.included?(m.output)

This is being called from inside the 'V10Engine' class, but this is fluentd 14.18:

irb(main):001:0> require 'fluent/version'
=> true
irb(main):002:0> Fluent::VERSION
=> "0.14.18"
irb(main):003:0> Fluent::VERSION > '0.12'
=> true

But for some reason the V14EventRouter isn't being used. Instead a new V10Engine is initialized. So this check:

 event_router = Engine.instance_variable_get(:@event_router)

is returning nil for some reason.

Answer 3 · 2017-06-29T16:16:55.000Z

I don't know how this code works. Examining the Engine instance from inside the plugin shows that it doesn't even have an 'event_router' instance variable.

Answer 4 · 2017-09-13T11:33:47.000Z

Running into the same issue - so stopped using this plugin for now. Any idea @cosmo0920?

Answer 5 · 2017-09-13T13:30:30.000Z

@Globegitter I think that we should request @sonots to release new version of this plugin.
Or, creating master version of this plugin with bundle exec rake build and install gem which is created under pkg/.

Answer 6 · 2017-09-13T13:39:53.000Z

Thank you for reminding this to me. I've released 0.3.0.

Answer 7 · 2017-09-13T13:41:13.000Z

FYI: You could've written Gemfile as:

gem 'fluent-plugin-reemit', git: 'https://github.com/sonots/fluent-plugin-reemit'

to use the master.

Answer 8 · 2017-09-14T17:46:02.000Z

This is still an issue with 0.3.0.

Answer 9 · 2017-09-14T17:49:19.000Z

Could you paste backtrace on the error?

Answer 10 · 2017-09-14T17:56:49.000Z

2017-09-14 10:54:06 -0700 [warn]: #0 fluent/log.rb:336:warn: reemit: NoMethodError undefined method `find' for nil:NilClass /Users/ryan/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/fluent-plugin-reemit-0.3.0/lib/fluent/plugin/out_reemit.rb:154:in `match'

Answer 11 · 2017-09-14T17:57:08.000Z

Thanks. I will fix.

Answer 12 · 2017-09-14T18:57:24.000Z

v0.3.1 is released.

Answer 13 · 2017-09-15T06:22:51.000Z

BTW, I recommend to use the label feature of Fluentd > v0.12 to achieve branching of data flow. See https://github.com/sonots/fluent-plugin-reemit#using-relabel-plugin-instead-of-reemit-plugin

If there is no extra demand, I will probably stop maintaining this plugin because the implementation of this plugin is too fragile to maintain.