flutter_elinux.h not C importable

Question

flutter_elinux.h not C importable

Closed this issue a year ago · 8 comments

flutter_elinux.h appears to be C-compatible by virtue of its extern "C" guard but it includes some definitions with reference parameters:

FLUTTER_EXPORT FlutterDesktopViewControllerRef
FlutterDesktopViewControllerCreate(
    const FlutterDesktopViewProperties& view_properties,
    FlutterDesktopEngineRef engine);

FLUTTER_EXPORT FlutterDesktopEngineRef FlutterDesktopEngineCreate(
    const FlutterDesktopEngineProperties& engine_properties);

This causes problems with languages such as Swift that do not support C++ interoperability (at least, in shipping versions).

Upstream raised and fixed this in flutter/flutter#75465.

Answer 1 · 2023-07-16T19:05:57.000Z

Also would be nice to import FlutterDesktopMessengerAddRef and FlutterDesktopMessengerRelease if possible.

Answer 2 · 2023-07-16T19:15:27.000Z

Should be fixed in https://github.com/PADL/flutter-embedded-linux/tree/lhoward/345 (didn't create a PR, per README).

Answer 3 · 2023-07-16T21:14:18.000Z

Thank you. Can you please create a PR with Developer’s Certificate of Origin (DCO) in your commit message? Also, please update (AUTHORS)[https://github.com/sony/flutter-embedded-linux/blob/master/AUTHORS] too.

Answer 4 · 2023-07-17T06:54:49.000Z

Also would be nice to import FlutterDesktopMessengerAddRef and FlutterDesktopMessengerRelease if possible.

Remaining task.

Answer 5 · 2023-07-17T07:00:28.000Z

I will do, I need to figure out how to build it before trying anything more substantial.

Answer 6 · 2023-07-17T07:17:15.000Z

Okay, thank you.

Answer 7 · 2023-07-17T11:22:06.000Z

Closing. Thank you so much, Ihoward!

Answer 8 · 2023-07-17T16:48:13.000Z

Thank you for merging so quickly. I've tested the latest main with my Swift wrapper and it is working :)