sony/nnabla

The role of parametric variable pv plays?

MiZhangWhuer opened this issue · 2 comments

In the graph_def.py, there exists a local variable pv:

pv.repeat_id = [repeat_id for repeat_id in v.repeat_id]

It seems that the pv has no effect on the from_proto function. Can we remove it in the from_proto function?

Thank you for your code review.

pv is useful here.
pv is the reference of g.variable[v.name] or g.parameters[v.name], Here, we use abbreviation pv to refer to one of them so that the code looks readable, avoid to duplicated g.variable[xxx].
So, you cannot remove pv from this scope.

Thanks!

I hope you got why pv is used in this sentence, so please let me close this.
If you feel unclear or have additional questions, please create new issue.