The role of parametric variable pv plays?
MiZhangWhuer opened this issue · 2 comments
MiZhangWhuer commented
In the graph_def.py, there exists a local variable pv:
nnabla/python/src/nnabla/core/graph_def.py
Line 843 in 7a1a713
It seems that the pv has no effect on the from_proto function. Can we remove it in the from_proto function?
TomonobuTsujikawa commented
Thank you for your code review.
pv is useful here.
pv is the reference of g.variable[v.name] or g.parameters[v.name], Here, we use abbreviation pv to refer to one of them so that the code looks readable, avoid to duplicated g.variable[xxx].
So, you cannot remove pv from this scope.
Thanks!
TomonobuTsujikawa commented
I hope you got why pv is used in this sentence, so please let me close this.
If you feel unclear or have additional questions, please create new issue.