soong-construction/dirt-rally-time-recorder

Update PyInstaller to 4.3

maxbechtold opened this issue · 5 comments

maxbechtold commented
  • Include dependency
  • Update Sqlite3 if possible, specify its version (Readme?)
  • If required update license texts
  • Create a new maintenance release
maxbechtold commented

This should resolve #58

maxbechtold commented

Windows Defender just quarantined timerecord.exe which I updated to v2.10.4, this might be related to bundling with the new PyInstaller version. Reopening to investigate.

maxbechtold commented

MS Defender suddenly detects timerecord.exe as "Win32/Wacatac.B!ml" after bundling it with PyInstaller 4.3 (up to version 4.2, this never occurred iirc).

VirusTotal Findings also increased from 1 red flag to 15 red flags.

These false-positives seem to be inherent to the bundling and compression applied by PyInstaller, which is not at all dissimilar from methods used for concealing/obfuscating malware: pyinstaller/pyinstaller#4633 (comment)

There should be an additional point in the Troubleshooting section, and maybe check in a few weeks time if VirusTotal findings go down for v2.10.4. If not, we might need to go back to PyInstaller 4.2

maxbechtold commented

VirusTotal findings are back to 1 again: https://www.virustotal.com/gui/file/9f32054accb0ae7f7302d8d575510333ac578264462ebdf7ff209c47a190e3d7?nocache=1

A hint under "Troubleshooting" might not be a good idea - if MS Defender or VirusTotal discredit DRTR, what could convince a user otherwise? Plus, the findings might actually be true after all...

maxbechtold commented

Resolved with version 2.10.5