sorich87/bootstrap-tour

Migration under MIT License

bdauton opened this issue · 73 comments

bdauton commented

Hi all,

As you know, Bootstrap 3 is now under MIT license. To follow their license and to allow GPLv2 projects to use this awesome bootstrap add-on, we need the approval of all contributors. To do so, it would be very cool if all of you fill this form: https://docs.google.com/forms/d/1U6Biw2jU2DFeNKTuy9F2jCMcvsEoI8cwbgeVj6vnWj4/viewform?usp=send_form

Thanks !

sorich87 commented

@LostCrew I think we need the approval from everyone who ever contributed code.

LostCrew commented

@sorich87 sorry then. it's gonna be long. is there a shortcut to take for this?

emmenko commented

Done as well

sorich87 commented

@LostCrew no 😟

@bdauton please can you put a link to the list of contributors who signed?

bdauton commented

Ok, 5 peoples in 2 days, it's gonna be long, and all contributors doesn't have email in their GitHub profile :-/

sorich87 commented

There's a way to get any contributor email. Load https://api.github.com/users/%username%/events/public (e.g. https://api.github.com/users/sorich87/events/public) and search for the email in the JSON response.

sorich87 commented

Well, I guess people are not reading the repo notifications. @bdauton let us know when you send the emails.

s7anley commented

Document is available only for view.

s7anley commented

Yop, my bad. Thanks.

mike-potter commented

What is the status of this? We can't get bootstrap-tour whitelisted on the Drupal.org site for use in distributions (like Open Atrium) until it switches from Apache to MIT license. Right now we are resorting to using a CDN link which makes it problematic for users behind firewalls. We'll be doing our conversion of Open Atrium to Bootstrap 3.x in the coming weeks and really look forward to using the latest bootstrap-tour also. Thanks!

mike-potter commented

Bumping this issue once more. The current Apache 2.0 license prevents bootstrap-tour from being white-listed for inclusion in Drupal-based distributions. I'd really like to get rid of the CDN link and have this library included in the Open Atrium distro. Is this issue dead or is there any way to get this license changed to MIT?

sorich87 commented

@mike-potter lack of time to complete that is the issue :(

mike-potter commented

@sorich87 is it lack of your time, or lack of response from some code contributors. Seems like other projects (like Bootstrap) have been through this and there should be ways to deal with people who contributed code but don't respond in a timely way.

But what's the real blocker here?

sorich87 commented

@mike-potter

All the biggest contributors are ok with the change. But, as you noticed, there's lack of response from some other contributors.

The solution would be to audit the commits from these contributors to see if their code is used, contact them individually and revert the commits if no response.

That's why I mentioned my lack of time. Do you want to do it?

mike-potter commented

I can't take over and actually "do it", but maybe we can open this up to get you more help.

As a reference, here is the very long related thread covering this same issue as it happened to Bootstrap itself: twbs/bootstrap#2054. You'll see that it was started in a similar manner (Drupal distros wanting to use Bootstrap). Had a lot of side-tracking discussion of MIT vs Apache and GPL2 vs GPL3 stuff.

Ultimately they were able to contact almost all code contributors and then finally reverted the code from the small number of people who said no (although then it looks like they just committed similar changes/fixes back, so not sure how "rewriting a commit" really works when it's a trivial commit).

In that thread, they also recommended using https://github.com/beberlei/license-manager.

Maybe you could set this up in license-manager somewhere (never used it so don't really know how it works). Or, at least set up some sort of public google doc with the list of contributors so we can keep track of who has said yes, who hasn't responded, etc. Then maybe we can restart this effort and really see what commits are left that might need to be reverted/rewritten.

sorich87 commented

Agreed. It would be great if anyone could help with that.

marclaporte commented

Hi!

As we saw in these two cases, it takes a very long time, but eventually, we succeed.
twbs/bootstrap#2054
Bttstrp/bootstrap-switch#347

We need to start to make sure new commits are in the new license, and then we work backwards to get all the previous commits. I just added two pull requests for this.

Big picture steps:

1- Announce intention: all new commits have to be dual-licensed MIT and current license. (Done)

2- Contact all the code committers, which still have code in the current master. Template example here: https://tiki.org/Bootstrap+License+change+request

3- Get them all to agree (The best is to vote +1 on this thread. An email works as well )

4- If some refuse or are unreachable, rewrite their contributions

5- Release new version as MIT

marclaporte commented

Here is a copy of the spreadsheet with previous approvals:
04/05/2014 16:39:08 YES LostCrew
04/05/2014 17:18:51 YES fczbkk
04/05/2014 17:29:14 YES sorich87
05/05/2014 09:58:24 YES emmenko
05/05/2014 13:58:25 YES martin-g
13/05/2014 18:03:22 YES test
14/05/2014 08:54:52 YES s7anley
19/05/2014 10:23:20 YES mm
04/05/2015 19:09:12 YES mike-potter
16/05/2015 20:18:37 YES brexis

And some stats:
https://github.com/sorich87/bootstrap-tour/graphs/contributors
https://www.openhub.net/p/bootstrap-tour/contributors?query=&sort=commits

To the following, please add +1 to this thread. Thanks!
@Genosite
@skahack
@ivanov
@rhertogh
@ramatevish
@mlissner
@kozak
@fabienpomerol
@javaguirre
@hfellmann (@fellmann)
@ericdegboe
@html5cat
@rolo
@edgardmessias
@msievers
@reubenbrown
@KyleMit
@mareksotak
@minrk
@pavarnos
@Hengjie
@TiddoLangerak
@aiccucs
@Esperancia
@borski
@ma-si
@dannon
@cvrebert
@mattmcneeney
@sdizier
@bdauton
@forest
@tmort
@kaihowl
@arnaudbreton
@eliasisrael
@usmanhalalit
@ragulka
@erwanjegouzo
@benoth
@gkorland
@evanleonard
@Amli

kozak commented

+1 (also signed the form now)

fabienpomerol commented

+1

Le ven. 7 août 2015 14:14, Marc Laporte notifications@github.com a écrit :

Here is a copy of the spreadsheet with previous approvals:
04/05/2014 16:39:08 YES LostCrew
04/05/2014 17:18:51 YES fczbkk
04/05/2014 17:29:14 YES sorich87
05/05/2014 09:58:24 YES emmenko
05/05/2014 13:58:25 YES martin-g
13/05/2014 18:03:22 YES test
14/05/2014 08:54:52 YES s7anley
19/05/2014 10:23:20 YES mm
04/05/2015 19:09:12 YES mike-potter
16/05/2015 20:18:37 YES brexis

And some stats:
https://github.com/sorich87/bootstrap-tour/graphs/contributors
https://www.openhub.net/p/bootstrap-tour/contributors?query=&sort=commits

To the following, please add +1 to this thread. Thanks!
@Genosite https://github.com/Genosite
@fczbkk https://github.com/fczbkk
@sdizier https://github.com/sdizier
@skahack https://github.com/SKAhack
@ivanov https://github.com/ivanov
@rhertogh https://github.com/rhertogh
@11Hengjie
@ramatevish https://github.com/ramatevish
@bdauton https://github.com/bdauton @forest https://github.com/forest
@mlissner https://github.com/mlissner
@kozak https://github.com/kozak
@Esperancia https://github.com/Esperancia
@tmort https://github.com/tmort
@borski https://github.com/borski
@kaihowl https://github.com/kaihowl
@arnaudbreton https://github.com/arnaudbreton
@eliasisrael https://github.com/eliasisrael
@fabienpomerol https://github.com/fabienpomerol
@javaguirre https://github.com/javaguirre
@ma-si https://github.com/ma-si
@hfellmann https://github.com/hfellmann
@ericdegboe https://github.com/ericdegboe
@usmanhalalit https://github.com/usmanhalalit
@html5cat https://github.com/html5cat
@ragulka https://github.com/ragulka
@erwanjegouzo https://github.com/erwanjegouzo
@rolo https://github.com/rolo
@edgardmessias https://github.com/edgardmessias
@TiddoLangerak https://github.com/TiddoLangerak
@msievers https://github.com/msievers
@dannon https://github.com/dannon
@reubenbrown https://github.com/reubenbrown
@benoth https://github.com/Benoth
@KyleMit https://github.com/KyleMit
@mattmcneeney https://github.com/mattmcneeney
@pavarnos https://github.com/pavarnos
@mareksotak https://github.com/mareksotak
@aiccucs https://github.com/aiccucs
@minrk https://github.com/minrk
@gkorland https://github.com/gkorland
@evanleonard https://github.com/evanleonard
@cvrebert https://github.com/cvrebert
@Amli https://github.com/Amli

—
Reply to this email directly or view it on GitHub
#257 (comment)
.

fellmann commented

👍 +1

msievers commented

+1

javaguirre commented

👍

rolo commented

+1

rhertogh commented

+1

skahack commented

+1

ericdegboe commented

+1

Le ven. 7 août 2015 à 14:57, reubenbrown notifications@github.com a
écrit :

+1

—
Reply to this email directly or view it on GitHub
#257 (comment)
.

KyleMit commented

+1 (how do I do that thumbs thing too - that seems neat)

Oh, like this :+1:

👍

Genosite commented

+1

mlissner commented

👍

ivanov commented

👍

html5cat commented

👍 :shipit:

minrk commented

👍

pavarnos commented

+1

Hengjie commented

+1

aiccucs commented

+1

marclaporte commented

Thank you for all the support! Keep it coming :-)

sorich87 commented

Thank you! @marclaporte

borski commented

+1

ma-si commented

+1

dannon commented

+1

cvrebert commented

+1

kaihowl commented

+1

On 30 Sep 2015, at 12:40, Marc Laporte notifications@github.com wrote:

To the users below, please, we need your +1 :-)
@sdizier
@bdauton
@forest
@tmort
@kaihowl
@arnaudbreton
@usmanhalalit
@ragulka
@erwanjegouzo
@gkorland
@evanleonard
@Amli

—
Reply to this email directly or view it on GitHub.

marclaporte commented

@bdauton made this request so we consider it as a +1

marclaporte commented

@usmanhalalit you fixed a typo (not code) so I am removing you from the list. Thanks for your contribution!
https://github.com/sorich87/bootstrap-tour/commits?author=usmanhalalit

tmort commented

+1 - Sorry this took so long

Amli commented

+1 - sorry for the delay, I really need to reactivate the github notifications

ragulka commented

+1 sorry for the delay, did not realise you need my vote :P

forest commented

+1 - sorry for the delay.

marclaporte commented

The commit by gkorland
fbbcaab
is in the file component.json which no longer exists

It is now in package.json, and the value has been changed, thus rewritten.
https://github.com/sorich87/bootstrap-tour/blob/master/package.json

So I consider this is resolved.

marclaporte commented

@arnaudbreton : you are the last one!

arnaudbreton commented

+1, OK for me. Sorry for the delay!

marclaporte commented

Super! It took 18 months from the initial report. Choose your license well, because it's a lot of work to change on a collaborative project!

Related commits:
e78b5b4
c6697d8
ae2d44b
19a7d71
876e72f
f536263

Let's fix some bugs, and proceed to a new release :-)