Always close database connections

[taldcroft]

Only a small minority of database connections are being explicitly closed. Use the DBI context manager to fix this.

skadev-ccosmos$ find mica -name "*.py" | xargs egrep  '(DBI\(|\.conn\.close\()'
mica/archive/aca_l0.py:        db = Ska.DBI.DBI(dbi='sqlite', server=dbfile)
mica/archive/aca_l0.py:    aca_db = Ska.DBI.DBI(dbi="sybase", server="sybase", user="aca_read")
mica/archive/aca_l0.py:        db = Ska.DBI.DBI(dbi='sqlite', server=dbfile)
mica/archive/aca_l0.py:        db = Ska.DBI.DBI(dbi='sqlite', server=dbfile)
mica/archive/aca_l0.py:            db = Ska.DBI.DBI(dbi='sqlite', server=dbfile, autocommit=False)
mica/archive/aca_l0.py:#        db = Ska.DBI.DBI(dbi='sqlite', server=db_file,
mica/archive/obsid_archive.py:        self._apstat = Ska.DBI.DBI(dbi='sybase', server='sqlsao',
mica/archive/obsid_archive.py:        self._aca_db = Ska.DBI.DBI(dbi='sybase', server='sybase',
mica/archive/obsid_archive.py:            db = Ska.DBI.DBI(dbi='sqlite', server=db_file,
mica/archive/obsid_archive.py:        db = Ska.DBI.DBI(dbi='sqlite', server=db_file,
mica/archive/obsid_archive.py:        db = Ska.DBI.DBI(dbi='sqlite', server=db_file,
mica/archive/asp_l1_proc.py:    apstat_db = Ska.DBI.DBI(dbi='sybase',
mica/archive/asp_l1_proc.py:        proc_db = Ska.DBI.DBI(dbi='sqlite', server=proc_db_file)
mica/archive/asp_l1_proc.py:        proc_db = Ska.DBI.DBI(dbi='sqlite', server=proc_db_file)
mica/archive/asp_l1_proc.py:    archdb = Ska.DBI.DBI(dbi='sqlite',
mica/archive/aca_dark/dark_cals_with_temp.py:db = DBI(dbi='sybase', server='sybase', user='aca_read', database='aca')
mica/vv/vv.py:        asp_l1_proc = Ska.DBI.DBI(dbi="sqlite", server=FILES['asp1_proc_table'])
mica/vv/core.py:        apstat = Ska.DBI.DBI(dbi='sybase',
mica/vv/core.py:        apstat.conn.close()
mica/vv/process.py:    asp_l1_proc = Ska.DBI.DBI(dbi="sqlite", server=FILES['asp1_proc_table'])
mica/vv/process.py:    asp_l1_proc = Ska.DBI.DBI(dbi="sqlite", server=FILES['asp1_proc_table'])
mica/catalog/catalog.py:#tdb = Ska.DBI(dbi='sybase', server='sybase',
mica/starcheck/starcheck.py:    aca_db = Ska.DBI.DBI(dbi='sybase', server='sybase', user='aca_read')
mica/starcheck/starcheck.py:    aca_db = Ska.DBI.DBI(dbi='sybase', server='sybase', user='aca_read')
mica/starcheck/starcheck.py:        db = Ska.DBI.DBI(dbi='sqlite', server=config['server'])
mica/starcheck/starcheck.py:    db = Ska.DBI.DBI(dbi='sqlite', server=config['server'])
mica/starcheck/starcheck.py:    dbh = Ska.DBI.DBI(dbi=sc_dbi, server=sc_server)
mica/starcheck/starcheck.py:        aca_db = Ska.DBI.DBI(dbi='sybase', server='sybase',
mica/starcheck/starcheck.py:        db = Ska.DBI.DBI(dbi='sqlite', server=config['server'])
mica/starcheck/starcheck.py:        db = Ska.DBI.DBI(dbi='sqlite', server=config['server'])
mica/report/report.py:    ocat_db = Ska.DBI.DBI(dbi='sybase', server='sqlsao', user='aca_ops', database='axafocat')
mica/report/report.py:    ocat_db.conn.close()
mica/report/report.py:    vv_db = Ska.DBI.DBI(dbi='sybase', server='sqlsao', user='jeanconn', database='axafvv')
mica/report/report.py:    vv_db = Ska.DBI.DBI(dbi='sybase', server='sqlsao', user='jeanconn', database='axafvv',
mica/report/report.py:        ACA_DB = Ska.DBI.DBI(dbi='sybase', server='sybase', user='aca_read')
mica/report/report.py:        ACA_DB = Ska.DBI.DBI(dbi='sybase', server='sybase', user='aca_read')
mica/report/report.py:    ACA_DB.conn.close()
mica/report/report.py:        ACA_DB = Ska.DBI.DBI(dbi='sybase', server='sybase', user='aca_read')
mica/report/report.py:    ACA_DB.conn.close()