souporserious/react-measure

React 16 support

jbyttow opened this issue · 4 comments

jbyttow commented

react-measure is not compatible with React 16 due to its dependency on React.createClass, this should be the only issue, but there may be others...

hkelly93 commented

@jbyttow I used your suggestion here #86.

Anyone feel free to comment or update my PR.

TrySound commented

@jbyttow react-measure does not use React.createClass. And all seems like work fine in my projects.

  • 👍1
AVickory commented

I believe the issue is specifically that if the Measure component's child is created using createReactClass from the "create-react-class" package then you get the parameter 1 is not of type "Element" error thrown here: https://github.com/que-etc/resize-observer-polyfill/blob/master/src/ResizeObserverSPI.js#L81.

AVickory commented

nvm just found #76