Assessment submissions can be modified, triggering unsubmission

Question

Assessment submissions can be modified, triggering unsubmission

Closed this issue 3 months ago · 4 comments

The 'save' feature seems to have been accidentally enabled for assessment submissions even after the submissions have been finalized. As a result, they can be modified, which automatically triggers an un-submission.

Screen.Recording.2024-04-08.at.11.38.21.PM-1.mov

Answer 1 · 2024-04-11T11:02:14.000Z

@josh1248 thanks for this report! Can you confirm which commit caused this? You said you checked till late Feb right?

Answer 2 · 2024-04-11T14:02:38.000Z

Likely due to admin/ staff role. Could you guys check again with a student role?

https://github.com/source-academy/backend/blob/410905ac4595c3cc339a8d5fb224b355178f77af/lib/cadet_web/controllers/answer_controller.ex#L20

Answer 3 · 2024-04-13T13:25:06.000Z

Tested this using the students login and the save button didnt show up as intended... sorry for the trouble guys 😓

Answer 4 · 2024-04-13T13:27:19.000Z

I will close this (fake) issue and update the frontend developer wiki about this so this wouldnt happen again