source-academy/modules

Mobile Workspace: Module tab reloading on each keystroke in editor

martin-henz opened this issue · 4 comments

martin-henz commented

Expected Behavior

Editor keystrokes should not affect module loading.

Current Behavior

Currently each editor keystroke reloads the currently loaded modules.

Steps to Reproduce

  1. Load: https://share.sourceacademy.org/oxhil
  2. press run
  3. open the runes tab
  4. start typing in editor

you will see that each keystroke restarts the animation.

Context

This is a critical issue in modules. Fixing it is necessary for current CS1101S.

ianyong commented

Fixed the desktop workspace through the use of memoization in source-academy/frontend#2331, but the mobile workspace still has this issue because the mobileControlBarProps being passed into it is constantly updating (thus making memoization ineffective). Possibly need to either memoize more components/variables in the code or refactor such that the side content tabs are not re-rendered when the control bar re-renders.

martin-henz commented

Reopening after renaming: The problem persists for mobile workspace, see
source-academy/frontend#2331

martin-henz commented

The issue should move to frontend

  • 👍1