source-academy/modules

[RUNE]: heart has too low resolution

Closed this issue · 3 comments

The heart rune is currently ugly because it doesn't have enough resolution. The edges of the polygon are clearly visible. Example:

https://share.sourceacademy.org/7gbki

Screen Shot 2023-01-30 at 10 45 11 AM

Compare with the ribbon, which has sufficient resolution.

When I took CS1101S, I seem to recall seeing earlier screenshots where the heart rune had indistinguishably smooth edges. However, the module we were learning with already had the low resolution heart, and has since stayed this way. Did something change in the past, perhaps for performance reasons?

When I took CS1101S, I seem to recall seeing earlier screenshots where the heart rune had indistinguishably smooth edges. However, the module we were learning with already had the low resolution heart, and has since stayed this way. Did something change in the past, perhaps for performance reasons?

Yes, this is a regression. We had a higher-resolution heart before, and I don't think there are performance reasons.

The fix involves changing a number from 10 to 100. I will have this in my upcoming PR.

image

import { show, heart } from "rune"; show(heart);