[CSG]: Recent changes broke patch's colorizePolygons

Question

Closed this issue 4 months ago · 9 comments

When attempting to run the snowglobe sample, the following error is shown in the REPL:

Line 11: ReferenceError: colorizePolygons is not defined

That name occurs in the JSCAD modelling library's patch file. It would appear that recent changes in master may have broken the CSG module.

Line 11 calls intersect() from the CSG module. A trivial example such as render(cube(silver)) still works without error.

Answer 1 · 2023-11-14T03:38:00.000Z

@leeyi45 would you happen to know of anything related to the build system that may have changed recently such that this would be impacted?

Answer 2 · 2023-11-14T04:15:48.000Z

I can confirm that the problem exists as of today, in sourceacademy.org. Here is the direct share link: https://share.sourceacademy.org/ab906

Answer 3 · 2023-11-14T04:18:41.000Z

I bumped the version of esbuild, that is the only possible breaking change that comes to mind

Answer 4 · 2024-03-11T08:42:24.000Z

Update: render(cube(silver)) also does not currently work at https://share.sourceacademy.org/ab906

Answer 5 · 2024-03-11T10:47:49.000Z

@leeyi45 at which commit was the version on esbuild bumped?

Answer 6 · 2024-03-11T11:16:50.000Z

Update: render(cube(silver)) also does not currently work at https://share.sourceacademy.org/ab906

I am currently able to run it:

Answer 7 · 2024-03-11T11:24:13.000Z

@leeyi45 at which commit was the version on esbuild bumped?

Likely in cad8822.

Answer 8 · 2024-03-11T11:29:25.000Z

I am currently able to run it:

Yep, could also run it locally, but not on the website

Answer 9 · 2024-03-11T12:13:43.000Z

Yep, could also run it locally, but not on the website

I followed the share link and edited it there. So it was actually running on sourceacademy.org.

Testing on both deployments, neither org nor NUS can run the snowglobe snippet, but they can run the cube.

If the snowglobe works locally, perhaps that's a clue?