source-foundry/font-v

Version not set in CFFFont table

alerque opened this issue · 0 comments

For fonts with CFF subroutines, there is a CFFFont element with a version property. This value is not getting set by font-v to match the surrounding font version.

For example here is a (simplified) diff of a font in the Libertinus font project with the version set by it's old internal build script and now my trying to build the same sources without inputting a version and setting the version later with font-v:

--- /home/caleb/scratch/Libertinus-6.12/LibertinusSans-Italic.otf	2020-06-28T15:56:49+03:00
+++ LibertinusSans-Italic.otf	2020-08-18T12:47:49.742210+03:00
@@ -2433,13 +2433,13 @@
   <head>
     <!-- Most of this table will be recalculated by the compiler -->
     <tableVersion value="1.0"/>
-    <fontRevision value="6.12"/>
-    <checkSumAdjustment value="0x30ef053d"/>
+    <fontRevision value="7.000"/>
+    <checkSumAdjustment value="0x4ed7a053"/>
     <magicNumber value="0x5f0f3cf5"/>
     <flags value="00000000 00000011"/>
     <unitsPerEm value="1000"/>
@@ -6966,7 +6966,7 @@
     <major value="1"/>
     <minor value="0"/>
     <CFFFont name="LibertinusSans-Italic">
-      <version value="6.120"/>
+      <version value="1.0"/>
       <Copyright value="Copyright Copyright 2012-2020 The Libertinus Project Authors."/>
       <FullName value="Libertinus Sans Italic"/>
       <FamilyName value="Libertinus Sans"/>