not active when viewing specific commits on github?
jaffee opened this issue · 4 comments
I'm using Chrome on OSX.
For example on this page: FeatureBaseDB/featurebase@19af6ad the extension does not appear to be active. The only indication I have is a greyed out "Configure Sourcegraph" at the top:
Is this expected behavior?
P.S. loving the extension otherwise - great work!
@ijsnow I see an error in the JS console
Hi @jaffee I'm glad you like the extension!
I see the same error as @nicksnyder which tells me that sourcegraph.com doesn't have that commit. To confirm this, I tried to find the commit in the sourcegraph UI and it definitely doesn't have it: https://sourcegraph.com/github.com/pilosa/pilosa/-/commit/19af6ad623937ad00b31a5b4783e3c45fce46db4.
Going further, I checked the commits page on GitHub and don't see the commit in there anymore. Is it possible that there was a force push removing that commit? How did you get to that page in the GitHub UI?
For code intelligence to work we need the revision to be in the actual repository. The question now is where is the commit? It seems like GitHub probably stores the patch itself which is why we can still see the diff even though the commit may not be in the tree anymore.
oh... this is rather interesting. That commit was linked to from this comment on the pull request FeatureBaseDB/featurebase#1628 (comment) which you'll notice no longer links to the same commit.
I clicked on the commit link in the email I got from github about that comment which looked like this:
I just talked to @travisturner and he confirmed that he did a force push and then manually updated that commit link.
Weird situation - sorry for the trouble! I'll close this.
Don't be sorry! It was no trouble at all. Sorry you experienced this issue and that you lost time trying to figure it out. I've opened an issue for investing time into coming up with a better UX when errors are encountered https://github.com/sourcegraph/browser-extensions/issues/144.