sourcegraph/browser-extensions

Browser context menu item missing

KattMingMing opened this issue ยท 1 comments

The browser context menu item to Enable Sourcegraph on this domain is not appearing. It seems like there may be an issue with how the extension adds this item. https://sourcegraph.com/github.com/sourcegraph/browser-extensions/-/blob/src/extension/scripts/background.tsx#L277:1

I suspect that it's trying to add the item multiple times causes an error. My understanding is that the extension API lacks a way to check if a context menu item is already added so we need to keep track of that.

Fix:
Move createEnableDomainContextMenu to runtime.OnInstalled

๐ŸŽ‰ This issue has been resolved in version 1.17.0 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€