Tests will only pass if user timezone is Pacific.
Closed this issue · 1 comments
dmitshur commented
Some of the tests parse a diff with timestamps in Pacific timezone, and expect the printed output to match byte for byte. This only happens if users' system timezone happens to also be Pacific.
This is why Travis tests failed previously.
Tests should be improved to work regardless of users' system timezone.
This can be reproduced by doing:
$ TZ=US/Mountain go test -v sourcegraph.com/sourcegraph/go-diff/diff
=== RUN TestParseHunkNoChunksize
--- PASS: TestParseHunkNoChunksize (0.00s)
=== RUN TestParseHunksAndPrintHunks
--- PASS: TestParseHunksAndPrintHunks (0.00s)
=== RUN TestParseFileDiffAndPrintFileDiff
--- FAIL: TestParseFileDiffAndPrintFileDiff (0.00s)
diff_test.go:129: sample_file.diff: printed file diff != original file diff
# PrintFileDiff output:
--- oldname 2009-10-11 16:12:20.000000000 -0600
+++ newname 2009-10-11 16:12:30.000000000 -0600
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
# Original:
--- oldname 2009-10-11 15:12:20.000000000 -0700
+++ newname 2009-10-11 15:12:30.000000000 -0700
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
diff_test.go:129: sample_file_extended.diff: printed file diff != original file diff
# PrintFileDiff output:
diff --git a/vcs/git_cmd.go b/vcs/git_cmd.go
index aa4de15..7c048ab 100644
--- oldname 2009-10-11 16:12:20.000000000 -0600
+++ newname 2009-10-11 16:12:30.000000000 -0600
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
# Original:
diff --git a/vcs/git_cmd.go b/vcs/git_cmd.go
index aa4de15..7c048ab 100644
--- oldname 2009-10-11 15:12:20.000000000 -0700
+++ newname 2009-10-11 15:12:30.000000000 -0700
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
=== RUN TestParseMultiFileDiffAndPrintMultiFileDiff
--- FAIL: TestParseMultiFileDiffAndPrintMultiFileDiff (0.00s)
diff_test.go:170: sample_multi_file.diff: printed multi-file diff != original multi-file diff
# PrintMultiFileDiff output:
diff --ruN a/oldname1 b/newname1
old mode 0777
new mode 0755
--- oldname1 2009-10-11 16:12:20.000000000 -0600
+++ newname1 2009-10-11 16:12:30.000000000 -0600
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
diff --ruN a/oldname2 b/newname2
--- oldname2 2009-10-11 16:12:20.000000000 -0600
+++ newname2 2009-10-11 16:12:30.000000000 -0600
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
# Original:
diff --ruN a/oldname1 b/newname1
old mode 0777
new mode 0755
--- oldname1 2009-10-11 15:12:20.000000000 -0700
+++ newname1 2009-10-11 15:12:30.000000000 -0700
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
diff --ruN a/oldname2 b/newname2
--- oldname2 2009-10-11 15:12:20.000000000 -0700
+++ newname2 2009-10-11 15:12:30.000000000 -0700
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
the other hand, a
misspelled word isn't
the end of the world.
diff_test.go:170: sample_multi_file_single.diff: printed multi-file diff != original multi-file diff
# PrintMultiFileDiff output:
diff --ruN a/oldname1 b/newname1
--- oldname1 2009-10-11 16:12:20.000000000 -0600
+++ newname1 2009-10-11 16:12:30.000000000 -0600
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
# Original:
diff --ruN a/oldname1 b/newname1
--- oldname1 2009-10-11 15:12:20.000000000 -0700
+++ newname1 2009-10-11 15:12:30.000000000 -0700
@@ -1,3 +1,9 @@
+This is an important
+notice! It should
+therefore be located at
+the beginning of this
+document!
+
This part of the
document has stayed the
same from version to
@@ -5,16 +11,10 @@
be shown if it doesn't
change. Otherwise, that
would not be helping to
-compress the size of the
-changes.
-
-This paragraph contains
-text that is outdated.
-It will be deleted in the
-near future.
+compress anything.
It is important to spell
-check this dokument. On
+check this document. On
=== RUN TestNoNewlineAtEnd
--- PASS: TestNoNewlineAtEnd (0.00s)
=== RUN TestFileDiff_Stat
--- PASS: TestFileDiff_Stat (0.00s)
FAIL
exit status 1
FAIL sourcegraph.com/sourcegraph/go-diff/diff 0.007s
dmitshur commented
Resolved via 3 commits 7eefa0f...a41379e.