sourcegraph/src-cli

src-cli-5.1.1 fails to build

Closed this issue · 4 comments

Hi all, I am the sourcegraph-cli package maintainer on Gentoo linux.
I am attempting to build sourcegraph-cli-5.1.1 with go 1.21 and getting the following:

william@linux1 src-cli $ pwd
/home/william/repos/github.com/sourcegraph/src-cli
william@linux1 src-cli $ git zap
william@linux1 src-cli $ git describe --tags
5.1.1
william@linux1 src-cli $ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
william@linux1 src-cli $ go build ./cmd/src
# golang.design/x/clipboard
clipboard_linux.c:15:10: fatal error: X11/Xlib.h: No such file or directory
   15 | #include <X11/Xlib.h>
      |          ^~~~~~~~~~~~
compilation terminated.
william@linux1 src-cli $

It looks like you have a dependency missing in developing.md.

Can you let me know what I'm missing?

Thanks,

William

Hey @williamh! Thanks for reporting. Looks like the dependencies of golang-design/clipboard are listed here: https://github.com/golang-design/clipboard#dependency

Hey @mrnugget thanks for the info.
Based on this, it looks like src-cli now has a hard dependency on libX11.
Can this be made optional some how so src-cli can still be used on non-X11 systems?

Thanks,

William

cc @jasonhawkharris who worked on the scout functionality which uses this. Jason, do you think you really need the clipboard functionality? Or is there maybe a different lib we could use without these build-time dependencies?