sous-chefs/logrotate

Running kitchen converge twice generates duplicate logrotate entries

mesgme opened this issue · 2 comments

Running kitchen converge twice using only a wrapper cookbook calling the logrotate cookbook leads to 2 duplicate entries in the /etc/cron.daily/logrotate file

Using chef kitchen
Chef version 12.20.3
Vagrant bento Ubuntu 16.04
logrotate cookbook 2.2.0

Hey There
It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you.
Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.

This seems to have been due to putting my only_if check at the beginning of the block not the end.