soywiz-archive/klock

Wrapped implementations do not implement equals()

Closed this issue · 1 comments

This means that only referential equality is used, and can break equality for upstream data classes even when the payloads are identical.

Easiest is probably to make the wrapped classes data classes, but if that doesn't work can implement equals (and hashcode).

Happy to send a PR for either option.

You can make a PR with data classes. Please add tests that verifies the equality new feature