Callbacks: "to, from" versus "from, to"

Question

Callbacks: "to, from" versus "from, to"

BennyHinrichs opened this issue 6 years ago · 3 comments

In some places in the docs, e.g. onNavigationChanged you say that the callback params are (to, from), and then in other places, e.g. /component/view.svelte:58, you say it's (from, to). Which one is it? When I run onNavigationChanged, it looks like (from, to) to me.

Answer 1 · 2019-08-17T00:51:23.000Z

@BennyHinrichs it is fn(from, to) for onNavigationChanged, onBeforeNavigation - the documentation has been updated.

Answer 2 · 2019-08-17T04:05:56.000Z

Excellent. I think it's still the old one in src/router.js:124,143.

Answer 3 · 2019-08-17T12:28:24.000Z

@BennyHinrichs Good catch, all update in a5c1b61 commit.