spacejam/sled

Auto flusher available for all platform

vincent-herlemont opened this issue · 1 comments

Here v0.34.7/src/db.rs#L75-L81 auto flush is restricted.

        #[cfg(all(
            not(miri),
            any(
                windows,
                target_os = "linux",
                target_os = "macos",
                target_os = "dragonfly",
                target_os = "freebsd",
                target_os = "openbsd",
                target_os = "netbsd",
            )
        ))]

@spacejam What is the original reason to restrict it?

I see here that you remove these restrictions. What are the implications? Is it possible to create a release including this commit?

bwqr commented

Hi there,

I guess I hit the auto flusher not available for all platform issue where the sled version is 0.34.7. I was developing an iOS application and using sled as persistent key value store. Any call to insert does not get persisted unless I call flush explicitly. Since it is not documented in the readme page, it was time consuming for me to debug this. Is there any reason for not enabling automatic flush in iOS platform? Does the project have any plan to enable this?

Thanks.