Contribution guide

Question

Contribution guide

lbailly opened this issue 7 years ago · 12 comments

lbailly commented 7 years ago

Hi Guys,

Congrats for the job!

I'm thinking about adding B2B Wallet WS support.

Did you provide any guide to help contributing to the project ?
How did you convert WSDL to structs for example ?

Thanks,

Ludovic

smgladkovskiy commented 7 years ago

👍

Answer 1 · 2018-03-14T19:34:30.000Z

Hi, Ludovic!

Thank you for your interest and sorry for the long response.

Now the project is deep development and we have not even imagined that we can interest someone with current progress. In view of this, the contribution guide was not formed. We will try the other day to draft it and introduce it to the community.

As for the generation of structures, there is a lot of manual work. Although initially the library gowsdl was very helpful.

And we will be very pleased with pull request! :)

Answer 2 · 2018-03-14T21:10:14.000Z

Hi Sergey,

Thanks for your response.
Happy to find other people interested in using Amadeus WS in golang :-)

I can see that you pushed updates and implemented newer versions of the services as well as soap4 new header that's great.

I'll take a deeper look and would appreciate if you could add a basic example using soap4 + call to a simple service in order to get started.

Not easy to implement soap client in GO, I'm using gowsdl for other API too.

Thanks,

Ludovic

Answer 3 · 2018-03-15T05:52:01.000Z

I'll take a deeper look and would appreciate if you could add a basic example using soap4 + call to a simple service in order to get started.

Coming soon!

Answer 4 · 2018-03-15T11:11:09.000Z

Examples added.

Answer 5 · 2018-03-15T18:23:48.000Z

Thanks, I'll clone the repo and try that soon

Answer 6 · 2018-03-20T06:51:31.000Z

Здравствуйте!. Хотелось бы увидеть пример в браузере. Какой адрес надо указать? С теми, что в примере не получается запустить пример.

Answer 7 · 2018-03-20T07:00:02.000Z

и еще один вопрос. То что в скобках (organizationId), надо поменять на то, что получено от amadeus?
Пример: в строке DataLength: formats.NumericInteger_Length1To15(passwordLength), вставляем в место "passwordLength" цифру 8. и так во всем коде.

Answer 8 · 2018-03-20T07:17:05.000Z

В файле "authenticate" надо ли поменять строки:
sa "github.com/tmconsulting/amadeus-golang-sdk/reqstructs/security_authenticate"
soap2 "github.com/tmconsulting/amadeus-golang-sdk/soap2.0" ????????????

Answer 9 · 2018-03-20T09:30:30.000Z

Hi, Pawel. I'm realy sorry, but i can't understand what exactly you want? This repo is SDK. What examples in browser do you need? Just use it to implement your own web app.
Or you can clarify you question.

Answer 10 · 2018-03-20T09:33:49.000Z

Two words about brackets.
Don't you saw lisp code? There are too many brackets too

Answer 11 · 2018-03-20T12:09:24.000Z

Понятно. Очень интересный проект. Спасибо.20.03.2018, 14:33, "Mikhail" <notifications@github.com>:Two words about brackets. Don't you saw lisp code? There are too many brackets too —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.